Bug 134658 - [iOS] MediaDocument should set a viewport
Summary: [iOS] MediaDocument should set a viewport
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-05 16:56 PDT by Dean Jackson
Modified: 2014-07-05 19:49 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2014-07-05 16:58 PDT, Dean Jackson 		zalan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-07-05 16:56:15 PDT 
[iOS] MediaDocument should set a viewport
Comment 1 Dean Jackson 2014-07-05 16:58:06 PDT 
Created attachment 234450 [details]
Patch
Comment 2 Dean Jackson 2014-07-05 17:03:54 PDT 
Committed r170827: <http://trac.webkit.org/changeset/170827>
Comment 3 Darin Adler 2014-07-05 19:49:50 PDT 
Comment on attachment 234450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234450&action=review

> Source/WebCore/html/MediaDocument.cpp:86
> +    rootElement->appendChild(headElement, IGNORE_EXCEPTION);

Should be headElement.release().

> Source/WebCore/html/MediaDocument.cpp:91
> +    headElement->appendChild(metaElement, IGNORE_EXCEPTION);

Should be metaElement.release().