WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
134655
Fast path for casting JSValue to JSDocument*.
https://bugs.webkit.org/show_bug.cgi?id=134655
Summary
Fast path for casting JSValue to JSDocument*.
Andreas Kling
Reported
2014-07-05 11:56:29 PDT
Fast path for casting JSValue to JSDocument*.
Attachments
Patch
(9.35 KB, patch)
2014-07-05 11:56 PDT
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Patch II
(11.39 KB, patch)
2015-01-19 16:39 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Patch II
(11.40 KB, patch)
2015-01-19 16:48 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2014-07-05 11:56:54 PDT
Created
attachment 234445
[details]
Patch
Antti Koivisto
Comment 2
2014-07-06 10:59:10 PDT
Comment on
attachment 234445
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=234445&action=review
> Source/WebCore/WebCore.xcodeproj/project.pbxproj:20760 > + ADDA94BF19686F8000453029 /* JSDocumentCustom.h */,
You should probably include this file to the patch too.
Andreas Kling
Comment 3
2015-01-19 16:39:11 PST
Created
attachment 244937
[details]
Patch II
Andreas Kling
Comment 4
2015-01-19 16:48:51 PST
Created
attachment 244938
[details]
Patch II
WebKit Commit Bot
Comment 5
2015-01-20 15:10:10 PST
Comment on
attachment 244938
[details]
Patch II Clearing flags on attachment: 244938 Committed
r178758
: <
http://trac.webkit.org/changeset/178758
>
WebKit Commit Bot
Comment 6
2015-01-20 15:10:18 PST
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 7
2015-01-21 10:15:19 PST
perf.webkit.org says this was a ~4% progression on Bindings/get-element-by-id <
https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mountainlion%22%2C%22Bindings%2Fget-element-by-id%3ARuns%22%5D%5D&zoom=%5B1421575570203%2C1421795645667.8208%5D
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug