Bug 134647 - Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS macro and generateTypeHelpers
Summary: Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS macro and gener...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 134653
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-05 01:32 PDT by Gyuyoung Kim
Modified: 2014-07-06 18:23 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.06 KB, patch)
2014-07-05 01:36 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (3.35 KB, patch)
2014-07-05 03:01 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (2.91 KB, patch)
2014-07-06 05:41 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (617.36 KB, application/zip)
2014-07-06 06:44 PDT, Build Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-07-05 01:32:09 PDT 
Though there is macro and generation tag for toFoo() and isFoo(), MathML hasn't used those things.
Comment 1 Gyuyoung Kim 2014-07-05 01:36:04 PDT 
Created attachment 234435 [details]
Patch
Comment 2 Gyuyoung Kim 2014-07-05 03:01:26 PDT 
Created attachment 234438 [details]
Patch
Comment 3 WebKit Commit Bot 2014-07-05 03:03:31 PDT 
Attachment 234438 [details] did not pass style-queue:


ERROR: Source/WebCore/mathml/MathMLElement.h:84:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Gyuyoung Kim 2014-07-05 08:27:17 PDT 
CC'ing Kling. could you take a look ?
Comment 5 WebKit Commit Bot 2014-07-05 10:36:25 PDT 
Comment on attachment 234438 [details]
Patch

Clearing flags on attachment: 234438

Committed r170825: <http://trac.webkit.org/changeset/170825>
Comment 6 WebKit Commit Bot 2014-07-05 10:36:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2014-07-05 10:55:28 PDT 
Re-opened since this is blocked by bug 134653
Comment 8 Gyuyoung Kim 2014-07-06 05:41:31 PDT 
Created attachment 234455 [details]
Patch
Comment 9 WebKit Commit Bot 2014-07-06 05:44:13 PDT 
Attachment 234455 [details] did not pass style-queue:


ERROR: Source/WebCore/mathml/MathMLElement.h:86:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Build Bot 2014-07-06 06:44:18 PDT 
Comment on attachment 234455 [details]
Patch

Attachment 234455 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5388528389193728

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 11 Build Bot 2014-07-06 06:44:21 PDT 
Created attachment 234456 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 12 Gyuyoung Kim 2014-07-06 07:00:23 PDT 
(In reply to comment #10)
> (From update of attachment 234455 [details])
> Attachment 234455 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/5388528389193728
> 
> New failing tests:
> media/W3C/video/networkState/networkState_during_loadstart.html

Looks unrelated.
Comment 13 Gyuyoung Kim 2014-07-06 07:01:13 PDT 
Comment on attachment 234455 [details]
Patch

Kling, I'm sorry for breaking debug build. I fixed the problem in last patch. Could you take a look again ?
Comment 14 WebKit Commit Bot 2014-07-06 18:22:58 PDT 
Comment on attachment 234455 [details]
Patch

Clearing flags on attachment: 234455

Committed r170833: <http://trac.webkit.org/changeset/170833>
Comment 15 WebKit Commit Bot 2014-07-06 18:23:03 PDT 
All reviewed patches have been landed.  Closing bug.