Turn on img@sizes compile flag
Created attachment 234408 [details]
Comment on attachment 234408 [details]
Alas, you need to do a bit more than this to turn it on by default. All you are doing here is toggling it to be on by default build-webkit, but not everyone uses this.
You should look at the patches that change FeatureDefines.xcconfig (which covers Apple's ports) as well as other configs for the remaining ports.
The r- isn't for the feature of course :)
Created attachment 234465 [details]
Thanks for reviewing! :)
I've added the flag and turned it on by default in a bunch of other places. I hope that covers everything.
Comment on attachment 234465 [details]
Clearing flags on attachment: 234465
Committed r170837: <http://trac.webkit.org/changeset/170837>
All reviewed patches have been landed. Closing bug.
This broke a test which has been causing red bots for two days now:
I see why this test can be flaky. I'll fix that tomorrow
On platform GTK 3 of this tests are failing. Reported here: https://bugs.webkit.org/show_bug.cgi?id=134756