Bug 134619 - [iOS WK2] Compositing layers draw outside page bounds
Summary: [iOS WK2] Compositing layers draw outside page bounds
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2014-07-03 16:56 PDT by Simon Fraser (smfr)
Modified: 2014-07-03 17:49 PDT (History)
7 users (show)

See Also:

Patch (6.85 KB, patch)
2014-07-03 16:59 PDT, Simon Fraser (smfr)
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-07-03 16:56:02 PDT
[iOS WK2] Compositing layers draw outside page bounds
Comment 1 Simon Fraser (smfr) 2014-07-03 16:59:59 PDT
Created attachment 234381 [details]
Comment 2 Simon Fraser (smfr) 2014-07-03 17:00:27 PDT
Comment 3 Benjamin Poulain 2014-07-03 17:25:09 PDT
Comment on attachment 234381 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=234381&action=review

> Source/WebKit2/UIProcess/ios/WKContentView.mm:570
> +    [_fixedClippingView setPosition:clippingBounds.location()];

UIView's setPosition is deprecated API

> Source/WebKit2/UIProcess/ios/WKContentView.mm:704
> +        FloatRect fixedPositionRect = _page->computeCustomFixedPositionRect(_page->unobscuredContentRect(), [[_webView scrollView] zoomScale]);

I think I'd prefere m_webPageProxy.displayedContentScale() here to be consistent with RemoteScrollingCoordinatorProxy::customFixedPositionRect().
I don't feel strongly about this, they should be the same values, do as you prefer.
Comment 4 Simon Fraser (smfr) 2014-07-03 17:49:06 PDT