Bug 134616 (profile_types) - Add more coverage for the profile_types_with_high_fidelity op code
Summary: Add more coverage for the profile_types_with_high_fidelity op code
Status: RESOLVED FIXED
Alias: profile_types
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-03 16:14 PDT by Saam Barati
Modified: 2014-07-06 21:49 PDT (History)
1 user (show)

See Also:

Attachments
patch (80.01 KB, patch)
2014-07-03 17:55 PDT, Saam Barati 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2014-07-03 16:14:29 PDT 
For more types to be profiled, we need better coverage.
Comment 1 Saam Barati 2014-07-03 17:55:20 PDT 
Created attachment 234384 [details]
patch

More operations are now being recorded by the profile_types_with_high_fidelity 
opcode. Specifically: function parameters, function return values,
function 'this' value, get_by_id, get_by_value, resolve nodes, function return 
values at the call site. Added more flags to the profile_types_with_high_fidelity
opcode so more focused tasks can take place when the instruction is
being linked in CodeBlock. Re-worked the type profiler to search 
through character offset ranges when asked for the type of an expression
at a given offset. Removed redundant calls to Structure::toStructureShape
in HighFidelityLog and TypeSet by caching calls based on StructureID.
Comment 2 Filip Pizlo 2014-07-06 20:41:38 PDT 
Comment on attachment 234384 [details]
patch

I will land it.
Comment 3 Filip Pizlo 2014-07-06 21:49:42 PDT 
Landed in http://trac.webkit.org/changeset/170836