Bug 134601 - Rationalize the interaction between GC and the SymbolTable lock
Summary: Rationalize the interaction between GC and the SymbolTable lock
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-03 10:30 PDT by Filip Pizlo
Modified: 2015-03-30 11:40 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-07-03 10:30:06 PDT 
Currently we have everything we need to ensure that we don't do GC things while holding the SymbolTable lock, and yet we still use a GCSafeConcurrentJITLocker because of the few things that slipped through, like exception throwing.

Also, we notifyWrite() on watchpoint sets while holding the SymbolTable lock, which seems super dangerous.

We should fix this.
Comment 1 Filip Pizlo 2015-03-30 11:40:11 PDT 
The notifyWrite part will be taken care of by https://bugs.webkit.org/show_bug.cgi?id=143232.