Bug 134582 - [iOS][WK2] Fix small bugs of dynamicViewportSizeUpdate that were causing inaccuracies in the computed target
Summary: [iOS][WK2] Fix small bugs of dynamicViewportSizeUpdate that were causing inac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-02 19:13 PDT by Benjamin Poulain
Modified: 2014-07-03 15:12 PDT (History)
6 users (show)

See Also:

Attachments
Patch (12.92 KB, patch)
2014-07-02 20:22 PDT, Benjamin Poulain 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-07-02 19:13:25 PDT 
[iOS][WK2] Fix small bugs of dynamicViewportSizeUpdate that were causing inaccuracies in the computed target
Comment 1 Benjamin Poulain 2014-07-02 20:22:33 PDT 
Created attachment 234310 [details]
Patch
Comment 2 Tim Horton 2014-07-02 21:07:42 PDT 
Comment on attachment 234310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234310&action=review

> Source/WebKit2/ChangeLog:16
> +        The first issue is that the unobscured content size was stored on integer coordinates. Because of that, it was

"on" should be "in"

> Source/WebKit2/ChangeLog:21
> +        on floating point. Since ARM64 does all those computation on double in the UIProcess, the value would be quite

computation*s* and double*s*

> Source/WebKit2/ChangeLog:27
> +        valid to have an exposed rect outside the page bounds, that areas is just under the obscured insets.

area, not areas
Comment 3 Benjamin Poulain 2014-07-03 15:12:18 PDT 
Committed r170773: <http://trac.webkit.org/changeset/170773>