RESOLVED FIXED 134578
[CMAKE] Add WEBKIT_OPTION_DEPEND macro to resolve macro dependency 
https://bugs.webkit.org/show_bug.cgi?id=134578
Summary [CMAKE] Add WEBKIT_OPTION_DEPEND macro to resolve macro dependency
Ryuan Choi
Reported 2014-07-02 18:09:53 PDT
For example, VIDEO_TRACK should be disable if VIDEO is disabled. I realized that legacy hack in OptionsEfl.cmake does not work well. Instead, I proposed simple macro, WEBKIT_OPTION_DEPEND to solve these issues.
Attachments
Patch (5.15 KB, patch)
2014-07-02 18:28 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2014-07-02 18:28:22 PDT
Created attachment 234304 [details] Patch
Gyuyoung Kim
Comment 2 2014-07-02 18:56:06 PDT
Comment on attachment 234304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234304&action=review Oh, nice. LGTM. > Source/cmake/OptionsEfl.cmake:92 > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_SLIDER ON) Looks this is not related to this patch.
Gyuyoung Kim
Comment 3 2014-07-02 19:04:33 PDT
Comment on attachment 234304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234304&action=review >> Source/cmake/OptionsEfl.cmake:92 >> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_SLIDER ON) > > Looks this is not related to this patch. Ah, I misunderstood.
Ryuan Choi
Comment 4 2014-07-03 01:05:23 PDT
Comment on attachment 234304 [details] Patch Clearing flags on attachment: 234304 Committed r170749: <http://trac.webkit.org/changeset/170749>
Ryuan Choi
Comment 5 2014-07-03 01:05:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.