WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
13456
REGRESSION: setTimeout "arguments" object gets shadowed by a local variable (Can't get past splash screen for KLM airlines)
https://bugs.webkit.org/show_bug.cgi?id=13456
Summary
REGRESSION: setTimeout "arguments" object gets shadowed by a local variable (...
tim bates
Reported
2007-04-23 11:13:27 PDT
1. go to
http://www.klm.com/
2. select country (UK) --> expect go to localised booking page OBTAINED: returned to splash page, with "Netherlands" as country and language options selected.
Attachments
test case
(532 bytes, text/html)
2007-04-25 03:28 PDT
,
Alexey Proskuryakov
no flags
Details
Fix by explicitly checking for arguments in VarDeclNode::evaluate
(9.71 KB, patch)
2007-05-25 07:17 PDT
,
Kimmo Kinnunen
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
tim bates
Comment 1
2007-04-23 11:17:24 PDT
works fine in Tiger release Safari
Alexey Proskuryakov
Comment 2
2007-04-23 11:27:24 PDT
Confirmed with
r21002
.
Alexey Proskuryakov
Comment 3
2007-04-25 03:27:48 PDT
var arguments; for (var c = 0; c < argpairs.length; c++) { var pair = argpairs[c].split("=", 2); arguments[pair[0]] = pair[1]; // fails here, because arguments is undefined } This works in shipping Safari and in Firefox because the variable doesn't shadow a predefined parameters object.
Alexey Proskuryakov
Comment 4
2007-04-25 03:28:17 PDT
Created
attachment 14173
[details]
test case
Darin Adler
Comment 5
2007-04-26 08:31:25 PDT
<
rdar://problem/5163497
>
Kimmo Kinnunen
Comment 6
2007-05-25 07:17:33 PDT
Created
attachment 14721
[details]
Fix by explicitly checking for arguments in VarDeclNode::evaluate The solution is not so nice because it uses explicit check. the error might show up somewhere else and of course if new similar properties are added to function call scope, same kind of bug will occur. Also the patch has has longer comment part than the actual code part. At least it gives a hint on why the bug exists..
Darin Adler
Comment 7
2007-05-25 09:39:36 PDT
Comment on
attachment 14721
[details]
Fix by explicitly checking for arguments in VarDeclNode::evaluate r=me
Darin Adler
Comment 8
2007-05-25 17:14:21 PDT
Committed revision 21790.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug