Bug 134523 – Subpixel rendering: Inline box decoration rounds to integral.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

and it makes border painting off by one (at best)

[zalan]

Created attachment 234229 [details]
Patch

[zalan]

Created attachment 234231 [details]
Patch

[zalan]

<rdar://problem/17530298>

[Build Bot]

Comment on attachment 234231 [details]
Patch

Attachment 234231 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5746401841512448

New failing tests:
css1/formatting_model/inline_elements.html
fast/inline/hidpi-inline-text-decoration-with-subpixel-value.html

[Build Bot]

Created attachment 234235 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 234231 [details]
Patch

Attachment 234231 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5942802106023936

New failing tests:
css1/formatting_model/inline_elements.html
fast/inline/hidpi-inline-text-decoration-with-subpixel-value.html

[Build Bot]

Created attachment 234236 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 234231 [details]
Patch

Attachment 234231 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5511881594765312

New failing tests:
css1/formatting_model/inline_elements.html
fast/inline/hidpi-inline-text-decoration-with-subpixel-value.html

[Build Bot]

Created attachment 234244 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Darin Adler]

Comment on attachment 234231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234231&action=review

EWS bots show tests failing.

> Source/WebCore/rendering/InlineFlowBox.cpp:1052
> -        LayoutRect boundsRect(roundedFrameRect());
> +        LayoutRect boundsRect = LayoutRect(topLeft(), size());

I don’t think this syntax is great:

    C a = C(b, c);

Two possibilities are what the existing code was doing:

    C a(b, c);

or if we prefer something that looks like assignment:

    C a = { b, c };

But also, it’s kind of annoying that InlineBox doesn’t have a function that returns this. It has logicalFrameRect but for some reason it doesn’t have frameRect. I think it’s really strange that the InlineBox class has x, y, width, height, left, top, size, right, and even bottom, but no function that just returns the whole thing as a rect.

> Source/WebCore/rendering/InlineFlowBox.cpp:1078
> +    LayoutRect rect = LayoutRect(topLeft(), size());

And again.

> Source/WebCore/rendering/InlineFlowBox.cpp:1287
> +    LayoutRect frameRect = LayoutRect(topLeft(), size());

And again.

> Source/WebCore/rendering/InlineFlowBox.cpp:1359
> +    LayoutRect frameRect = LayoutRect(topLeft(), size());

And again.

[zalan]

Created attachment 234507 [details]
Patch

[zalan]

Comment on attachment 234507 [details]
Patch

EWS testing.

[Darin Adler]

Comment on attachment 234507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234507&action=review

> Source/WebCore/rendering/InlineBox.h:213
> +    // FIXME: position/size related functions need cleanup.

While I agree with the sentiment, I don’t think this is a helpful FIXME.

[zalan]

(In reply to comment #13)
> (From update of attachment 234507 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234507&action=review
> 
> > Source/WebCore/rendering/InlineBox.h:213
> > +    // FIXME: position/size related functions need cleanup.
> 
> While I agree with the sentiment, I don’t think this is a helpful FIXME.
Indeed, I'll remove it before landing.

InlineBox should offer similar set of bounds (position/size) APIs as RenderBox. bug 134702

[zalan]

Created attachment 234543 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 234543 [details]
Patch

Clearing flags on attachment: 234543

Committed r170875: <http://trac.webkit.org/changeset/170875>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.