RESOLVED FIXED 134521
iOS should use shared code to determine the system marketing version 
https://bugs.webkit.org/show_bug.cgi?id=134521
Summary iOS should use shared code to determine the system marketing version
Mark Rowe (bdash)
Reported 2014-07-01 16:20:24 PDT
The iOS implementation of systemMarketingVersion is currently a FIXME. UserAgentIOS.mm has an implementation under the name osMarketingVersion that's virtually identical to the OS X version. We should only have a single copy of the code.
Attachments
Patch (37.52 KB, patch)
2014-07-01 16:27 PDT, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2014-07-01 16:27:12 PDT
Created attachment 234214 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-07-02 14:46:44 PDT
Comment on attachment 234214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234214&action=review > Source/WebCore/page/cocoa/UserAgent.mm:38 > + return [systemMarketingVersion() stringByReplacingOccurrencesOfString:@"." withString:@"_"]; It's sad that we go from String to NSString* and back here.
WebKit Commit Bot
Comment 3 2014-07-02 15:39:05 PDT
Comment on attachment 234214 [details] Patch Clearing flags on attachment: 234214 Committed r170730: <http://trac.webkit.org/changeset/170730>
WebKit Commit Bot
Comment 4 2014-07-02 15:39:10 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2014-07-03 09:54:43 PDT
Comment on attachment 234214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234214&action=review >> Source/WebCore/page/cocoa/UserAgent.mm:38 >> + return [systemMarketingVersion() stringByReplacingOccurrencesOfString:@"." withString:@"_"]; > > It's sad that we go from String to NSString* and back here. WTF::String dose have a function to do this. return systemMarketingVersion.replace('.', '_');
Note You need to log in before you can comment on or make changes to this bug.