Possible crash in IconDatabase in WebCore::IconDatabase::dispatchDidRemoveAllIconsOnMainThread
The main thread callbacks from the background thread reference "this". But in WebKit2 land with WebContexts coming and going, there's no guarantee "this" will still be around.
My proposed fix is for the WebCore::IconDatabase's owner (In this case WebIconDatabase) to detect the situation where the WebCore::IconDatabase is not yet finished and hang around until it is.
Created attachment 234207 [details]
Comment on attachment 234207 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=234207&action=review
> + // If there's still callbacks in flight from the sync thread we cannot possibly be closed.
Grammar nit: "If there are still callbacks"
> + // Even if there's no more pending callbacks the database might otherwise still be open.