Bug 134491 - Subpixel rendering: Pixel crack in breadcrumbs at devforums.apple.com.
Summary: Subpixel rendering: Pixel crack in breadcrumbs at devforums.apple.com.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL: https://devforums.apple.com/community...
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2014-07-01 08:07 PDT by zalan
Modified: 2014-07-01 10:25 PDT (History)
9 users (show)

See Also:


Attachments
Patch (10.35 KB, patch)
2014-07-01 08:36 PDT, zalan
simon.fraser: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-07-01 08:07:22 PDT
There’s a 1-pixel white vertical line going through the navigation breadcrumbs at the top of Developer Forums posts at devforums.apple.com. 
https://devforums.apple.com/community/safari/plugins


<rdar://problem/17499160>
Comment 1 zalan 2014-07-01 08:36:05 PDT
Created attachment 234166 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-07-01 09:57:03 PDT
Comment on attachment 234166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234166&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1152
> -    LayoutUnit computedXPosition = minimumValueForLength(fillLayer->xPosition(), availableWidth, true);
> +    LayoutUnit computedXPosition = minimumValueForLength(fillLayer->xPosition(), availableWidth, false);

Classic boolean trap. No idea what true/false mean.
Comment 3 zalan 2014-07-01 10:18:47 PDT
(In reply to comment #2)
> (From update of attachment 234166 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234166&action=review
> 
> > Source/WebCore/rendering/RenderBoxModelObject.cpp:1152
> > -    LayoutUnit computedXPosition = minimumValueForLength(fillLayer->xPosition(), availableWidth, true);
> > +    LayoutUnit computedXPosition = minimumValueForLength(fillLayer->xPosition(), availableWidth, false);
> 
> Classic boolean trap. No idea what true/false mean.

bug 134495
Comment 4 WebKit Commit Bot 2014-07-01 10:21:05 PDT
Comment on attachment 234166 [details]
Patch

Rejecting attachment 234166 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 234166, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5347005584900096
Comment 5 zalan 2014-07-01 10:25:33 PDT
Committed r170646: <http://trac.webkit.org/changeset/170646>