Bug 134476 – [GTK] Annotations for WebResource.get_data produce wrong signature in Vala binding

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

The get_data method of WebKit.WebResource is currently unusable from Vala code, because the method signature in the .vapi file is incorrect.

Currently the generated Vala signature is:

  public async uint8 get_data (GLib.Cancellable? cancellable, out size_t length) throws GLib.Error;

the expected signature is:

  [CCode (array_length_type = "size_t")]
  public async uint8[] get_data (GLib.Cancellable? cancellable) throws GLib.Error;

I have checked that applying this change to the webkit2gtk-3.0.vapi file manually & linking against webkit2gtk version 2.4.2 works, but I don't have the capacity right now to compile webkit to find out what changes to the annotations are required to reach this result.
If someone could point me to the right documentation, I'd be willing to submit a patch.

[Evan Nemerson]

Created attachment 234132 [details]
[GTK] fix WebKit.WebResource.get_data_finish return value annotations

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Comment on attachment 234132 [details]
[GTK] fix WebKit.WebResource.get_data_finish return value annotations

Thanks for the patch. It looks good to me, but you need to fill a changelog entry, see http://www.webkit.org/coding/contributing.html

[Carlos Garcia Campos]

Created attachment 234151 [details]
Patch for landing

Added changelog entry

[WebKit Commit Bot]

Comment on attachment 234151 [details]
Patch for landing

Clearing flags on attachment: 234151

Committed r170633: <http://trac.webkit.org/changeset/170633>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.