Bug 134473 - [iOS] languageSpecificFallbackFont() is not consistent
Summary: [iOS] languageSpecificFallbackFont() is not consistent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-30 16:57 PDT by Myles C. Maxfield
Modified: 2014-06-30 17:27 PDT (History)
10 users (show)

See Also:


Attachments
Patch (4.13 KB, patch)
2014-06-30 16:59 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (4.18 KB, patch)
2014-06-30 17:07 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (4.23 KB, patch)
2014-06-30 17:11 PDT, Myles C. Maxfield
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-06-30 16:57:56 PDT
[iOS] languageSpecificFallbackFont() is not consistent
Comment 1 Myles C. Maxfield 2014-06-30 16:59:36 PDT
Created attachment 234121 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-30 17:02:37 PDT
Attachment 234121 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2014-06-30 17:06:20 PDT
Comment on attachment 234121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234121&action=review

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:155
> +    if (c < 0x1401)
> +        return LanguageSpecificFont::None;

Looks to me like this changes behavior. The old code would return LanguageSpecificFont::Khmer for 0x1200-0x1400.
Comment 4 Myles C. Maxfield 2014-06-30 17:07:06 PDT
Created attachment 234124 [details]
Patch
Comment 5 Myles C. Maxfield 2014-06-30 17:08:35 PDT
Comment on attachment 234121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234121&action=review

>> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:155
>> +        return LanguageSpecificFont::None;
> 
> Looks to me like this changes behavior. The old code would return LanguageSpecificFont::Khmer for 0x1200-0x1400.

Yeah, you're right. Yet another reason why we need to be consistent!
Comment 6 Myles C. Maxfield 2014-06-30 17:11:34 PDT
Created attachment 234125 [details]
Patch
Comment 7 Myles C. Maxfield 2014-06-30 17:27:06 PDT
http://trac.webkit.org/changeset/170618