WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
134468
Make TransformIterator::TransformIterator() take rvalue references
https://bugs.webkit.org/show_bug.cgi?id=134468
Summary
Make TransformIterator::TransformIterator() take rvalue references
Daniel Bates
Reported
2014-06-30 16:30:35 PDT
We should add a constructor for TransformIterator::TransformIterator() that takes rvalue references so that we can actually use move semantics to move its passed arguments. Currently TransformIterator::TransformIterator() always copies its arguments.
Attachments
Patch
(1.68 KB, patch)
2014-06-30 16:31 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
Patch
(2.12 KB, patch)
2014-06-30 16:54 PDT
,
Daniel Bates
darin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2014-06-30 16:31:25 PDT
Created
attachment 234113
[details]
Patch
Darin Adler
Comment 2
2014-06-30 16:34:26 PDT
Comment on
attachment 234113
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=234113&action=review
> Source/WTF/ChangeLog:3 > + Actually use move semantics when calling TransformIterator::TransformIterator() with rvalue references
I don’t understand the point of the word “actually” here.
Daniel Bates
Comment 3
2014-06-30 16:54:25 PDT
Created
attachment 234120
[details]
Patch
Daniel Bates
Comment 4
2014-06-30 16:58:41 PDT
(In reply to
comment #2
)
> (From update of
attachment 234113
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=234113&action=review
> > > Source/WTF/ChangeLog:3 > > + Actually use move semantics when calling TransformIterator::TransformIterator() with rvalue references > > I don’t understand the point of the word “actually” here.
As we discussed in-person today (06/30), the purpose of this patch is to support a constructor that takes rvalue-references. It's actually sufficient to only have such a constructor. I updated the title of this bug and attached an updated patch.
Daniel Bates
Comment 5
2014-06-30 17:01:05 PDT
Committed
r170615
: <
http://trac.webkit.org/changeset/170615
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug