RESOLVED FIXED 134467
WebBackForwardListItems should hold on to PageState objects 
https://bugs.webkit.org/show_bug.cgi?id=134467
Summary WebBackForwardListItems should hold on to PageState objects
Anders Carlsson
Reported 2014-06-30 16:14:08 PDT
WebBackForwardListItems should hold on to PageState objects
Attachments
Patch (4.53 KB, patch)
2014-06-30 16:14 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-06-30 16:14:25 PDT
Created attachment 234111 [details] Patch
Darin Adler
Comment 2 2014-06-30 16:19:42 PDT
Comment on attachment 234111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234111&action=review OK > Source/WebKit2/Shared/WebBackForwardListItem.cpp:41 > + m_pageState.mainFrameState.originalURLString = originalURL; > + m_pageState.mainFrameState.urlString = url; > + m_pageState.title = title; No constructor for PageState? Is it just a struct? > Source/WebKit2/Shared/WebBackForwardListItem.cpp:69 > + encoder << m_pageState.mainFrameState.originalURLString; > + encoder << m_pageState.mainFrameState.urlString; > + encoder << m_pageState.title; No helper function for pageState? Doesn’t have to be a member function.
Anders Carlsson
Comment 3 2014-06-30 16:23:54 PDT
(In reply to comment #2) > (From update of attachment 234111 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234111&action=review > > OK > > > Source/WebKit2/Shared/WebBackForwardListItem.cpp:41 > > + m_pageState.mainFrameState.originalURLString = originalURL; > > + m_pageState.mainFrameState.urlString = url; > > + m_pageState.title = title; > > No constructor for PageState? Is it just a struct? Yes. > > > Source/WebKit2/Shared/WebBackForwardListItem.cpp:69 > > + encoder << m_pageState.mainFrameState.originalURLString; > > + encoder << m_pageState.mainFrameState.urlString; > > + encoder << m_pageState.title; > > No helper function for pageState? Doesn’t have to be a member function. This is just temporary - we don't want to encode and decode WebBackForwardListItems.
Anders Carlsson
Comment 4 2014-06-30 16:27:04 PDT
Committed r170613: <http://trac.webkit.org/changeset/170613>
Note You need to log in before you can comment on or make changes to this bug.