Bug 134467 - WebBackForwardListItems should hold on to PageState objects
Summary: WebBackForwardListItems should hold on to PageState objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-30 16:14 PDT by Anders Carlsson
Modified: 2014-06-30 16:27 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.53 KB, patch)
2014-06-30 16:14 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-06-30 16:14:08 PDT 
WebBackForwardListItems should hold on to PageState objects
Comment 1 Anders Carlsson 2014-06-30 16:14:25 PDT 
Created attachment 234111 [details]
Patch
Comment 2 Darin Adler 2014-06-30 16:19:42 PDT 
Comment on attachment 234111 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234111&action=review

OK

> Source/WebKit2/Shared/WebBackForwardListItem.cpp:41
> +    m_pageState.mainFrameState.originalURLString = originalURL;
> +    m_pageState.mainFrameState.urlString = url;
> +    m_pageState.title = title;

No constructor for PageState? Is it just a struct?

> Source/WebKit2/Shared/WebBackForwardListItem.cpp:69
> +    encoder << m_pageState.mainFrameState.originalURLString;
> +    encoder << m_pageState.mainFrameState.urlString;
> +    encoder << m_pageState.title;

No helper function for pageState? Doesn’t have to be a member function.
Comment 3 Anders Carlsson 2014-06-30 16:23:54 PDT 
(In reply to comment #2)
> (From update of attachment 234111 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234111&action=review
> 
> OK
> 
> > Source/WebKit2/Shared/WebBackForwardListItem.cpp:41
> > +    m_pageState.mainFrameState.originalURLString = originalURL;
> > +    m_pageState.mainFrameState.urlString = url;
> > +    m_pageState.title = title;
> 
> No constructor for PageState? Is it just a struct?

Yes.

> 
> > Source/WebKit2/Shared/WebBackForwardListItem.cpp:69
> > +    encoder << m_pageState.mainFrameState.originalURLString;
> > +    encoder << m_pageState.mainFrameState.urlString;
> > +    encoder << m_pageState.title;
> 
> No helper function for pageState? Doesn’t have to be a member function.

This is just temporary - we don't want to encode and decode WebBackForwardListItems.
Comment 4 Anders Carlsson 2014-06-30 16:27:04 PDT 
Committed r170613: <http://trac.webkit.org/changeset/170613>