Bug 134455 - CodeBlock::stronglyVisitWeakReferences should mark DFG::CommonData::weakStructureReferences
Summary: CodeBlock::stronglyVisitWeakReferences should mark DFG::CommonData::weakStruc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-30 14:24 PDT by Mark Hahnenberg
Modified: 2014-06-30 15:22 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.35 KB, patch)
2014-06-30 14:26 PDT, Mark Hahnenberg 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-06-30 14:24:54 PDT 
Otherwise we get hanging pointers which can cause us to die later.
Comment 1 Mark Hahnenberg 2014-06-30 14:26:52 PDT 
Created attachment 234093 [details]
Patch
Comment 2 Geoffrey Garen 2014-06-30 14:34:17 PDT 
Comment on attachment 234093 [details]
Patch

r=me

Any way to regression test this? Maybe even something that only crashes in Zombie mode?
Comment 3 Mark Hahnenberg 2014-06-30 14:51:52 PDT 
(In reply to comment #2)
> (From update of attachment 234093 [details])
> r=me
> 
> Any way to regression test this? Maybe even something that only crashes in Zombie mode?

It was a pre-existing regression test that caught this, so I think we're ok.
Comment 4 Mark Hahnenberg 2014-06-30 15:22:59 PDT 
Committed r170604: <http://trac.webkit.org/changeset/170604>