Encode/decode CFURLRequestRefs when USE(CFNETWORK) is enabled

[Pratik Solanki]

We current encode/decode NSURLRequest to send over the wire. We can just use CFURLRequestRef on iOS.

[Pratik Solanki]

<rdar://problem/17510980>

[Pratik Solanki]

Created attachment 234092 [details]
Patch

[Sam Weinig]

Comment on attachment 234092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234092&action=review

> Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:64
> +        CFURLRequestSetHTTPRequestBody((CFMutableURLRequestRef)(requestToSerialize.get()), nil);
> +        CFURLRequestSetHTTPRequestBodyStream((CFMutableURLRequestRef)(requestToSerialize.get()), nil);

These casts scare me.  Can we at least use the checked_cf_cast?

[Pratik Solanki]

Comment on attachment 234092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234092&action=review

>> Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:64
>> +        CFURLRequestSetHTTPRequestBodyStream((CFMutableURLRequestRef)(requestToSerialize.get()), nil);
> 
> These casts scare me.  Can we at least use the checked_cf_cast?

I resorted to plain old cast since static_cast didn't work and it seems dilemma I would have to combine it with const_cast. The NSURLRequest version of the code used C casts so I just used that. I didn't know about checked_cf_cast! I tried that but that also ran into const issues. Likely would have to use another const_cast along with it. I am going to try something different instead. New patch coming up.

[Pratik Solanki]

Created attachment 234168 [details]
Patch

[Andreas Kling]

Comment on attachment 234168 [details]
Patch

OK! r=me

[Pratik Solanki]

Committed r170685: <http://trac.webkit.org/changeset/170685>