Bug 134450 - add registers on armv7 css jit
Summary: add registers on armv7 css jit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Enhancement
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-30 12:42 PDT by Alex Christensen
Modified: 2014-06-30 14:28 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.11 KB, patch)
2014-06-30 12:45 PDT, Alex Christensen 		ggaren: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (754.69 KB, application/zip)
2014-06-30 13:16 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-06-30 12:42:29 PDT 
We can use registers beyond r7, which means we have enough registers to always compile css selectors.  Let's make this always succeed.
Comment 1 Alex Christensen 2014-06-30 12:45:01 PDT 
Created attachment 234086 [details]
Patch
Comment 2 Geoffrey Garen 2014-06-30 13:14:34 PDT 
Comment on attachment 234086 [details]
Patch

r=me
Comment 3 Build Bot 2014-06-30 13:16:42 PDT 
Comment on attachment 234086 [details]
Patch

Attachment 234086 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4695064982847488

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 4 Build Bot 2014-06-30 13:16:47 PDT 
Created attachment 234089 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Alex Christensen 2014-06-30 14:28:28 PDT 
I'm pretty sure that failure was not because of this change.

I added a change to the register ranges in isValidRegister and isCallerSavedRegister and committed to http://trac.webkit.org/changeset/170598