WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
134448
Reduce memory required for js/typedarray-zero-size.js
https://bugs.webkit.org/show_bug.cgi?id=134448
Summary
Reduce memory required for js/typedarray-zero-size.js
Michael Saboff
Reported
2014-06-30 10:11:34 PDT
LayoutTests/js/script-tests/typedarray-zero-size.js uses ~190MB which can cause havoc on devices with small amounts of memory. This is especially true when running JSC stress tests where multiple instances of the test run concurrently. The test can be modified to still test for the original bug fixed in <
http://trac.webkit.org/changeset/158583
>, while using less memory.
Attachments
Patch
(1.16 KB, patch)
2014-06-30 10:14 PDT
,
Michael Saboff
darin
: review+
Details
Formatted Diff
Diff
Patch with loop count of 4000
(1.35 KB, patch)
2014-06-30 11:20 PDT
,
Michael Saboff
mhahnenberg
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2014-06-30 10:14:26 PDT
Created
attachment 234079
[details]
Patch Verified that this catches the original issue by backing out the code change in <
http://trac.webkit.org/changeset/158583
>
Michael Saboff
Comment 2
2014-06-30 10:37:39 PDT
Committed
r170586
: <
http://trac.webkit.org/changeset/170586
>
Michael Saboff
Comment 3
2014-06-30 11:19:00 PDT
The first patch fixed the memory use issue on most devices. Still fails on an older iPad. Going to reduce the loop count.
Michael Saboff
Comment 4
2014-06-30 11:20:23 PDT
Created
attachment 234082
[details]
Patch with loop count of 4000 With a loop count of 4000, we still catch the original issue and it works on all the smaller memory devices I tested.
Mark Hahnenberg
Comment 5
2014-06-30 11:21:50 PDT
Comment on
attachment 234082
[details]
Patch with loop count of 4000 r=me
Michael Saboff
Comment 6
2014-06-30 11:22:54 PDT
Committed
r170591
: <
http://trac.webkit.org/changeset/170591
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug