Bug 134436 – [EFL] Fix occurrence of two cursors on WK2 EFL

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[KwangHyuk]

Created attachment 234060 [details]
Patch for fixing occurrence of two cursor images on WK2 EFL.

Currently I could notice two different cursor images when I used WK2 EFL's mini browser whenever mouse cursor gets into the banner area on the google.com site. In addition, there are similar issues on other sites too.
This patch is just for allowing only one cursor image for WK2 EFL.

[WebKit Commit Bot]

Attachment 234060 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[KwangHyuk]

Created attachment 234061 [details]
Add bug id to Changelog.

Add bug id to Changelog.

[Ryuan Choi]

Comment on attachment 234061 [details]
Add bug id to Changelog.

View in context: https://bugs.webkit.org/attachment.cgi?id=234061&action=review

> Source/WebKit2/ChangeLog:5
> +        ecore_x_window_cursor is released when ecore_evas_object_cursor should be shown in order to avoid occurrence of two cursors.

This comment should be below of "Reviewed by NOBODY..."

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:473
> +    ecore_x_window_cursor_set(getEcoreXWindow(ecoreEvas), 0);

At least, it should be in the guard #ifdef HAVE_ECORE_X

[Gyuyoung Kim]

Comment on attachment 234061 [details]
Add bug id to Changelog.

View in context: https://bugs.webkit.org/attachment.cgi?id=234061&action=review

r- because of comments.

> Source/WebKit2/ChangeLog:3
> +        Fix occurrence of two cursors on WK2 EFL.

Please add [EFL] prefix in bug title.

[KwangHyuk]

Created attachment 234078 [details]
Update the patch according to reviewer's comment.

[KwangHyuk]

Created attachment 234173 [details]
Update changelog.

Update "reviewed by" to Changelog.

[Gyuyoung Kim]

Comment on attachment 234173 [details]
Update changelog.

View in context: https://bugs.webkit.org/attachment.cgi?id=234173&action=review

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:472
>      // ecore_evas takes care of freeing the cursor object.

Move this comment to 475 line as below.

#ifdef HAVE_ECORE_X
    ecore_x_window_cursor_set(getEcoreXWindow(ecoreEvas), 0);
#endif

// ecore_evas takes care of freeing the cursor object.
ecore_evas_object_cursor_set(ecoreEvas, cursorObject.release(), EVAS_LAYER_MAX, hotspotX, hotspotY);

[KwangHyuk]

Created attachment 234238 [details]
Apply reviewer's comment.

[KwangHyuk]

> Move this comment to 475 line as below.

Done. :)

[WebKit Commit Bot]

Comment on attachment 234238 [details]
Apply reviewer's comment.

Clearing flags on attachment: 234238

Committed r170696: <http://trac.webkit.org/changeset/170696>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.