Bug 134435 - Flags value of SourceCodeKey should be unique for each case.
Summary: Flags value of SourceCodeKey should be unique for each case.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-29 03:42 PDT by Daewoong Jang
Modified: 2014-07-07 11:07 PDT (History)
11 users (show)

See Also:

Attachments
patch (1.64 KB, application/octet-stream)
2014-06-29 03:45 PDT, Daewoong Jang 		buildbot: commit-queue-
Details
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (629.87 KB, application/zip)
2014-07-01 23:30 PDT, Build Bot 		no flags Details
updated patch (1.55 KB, patch)
2014-07-02 18:05 PDT, Daewoong Jang 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (525.72 KB, application/zip)
2014-07-02 21:11 PDT, Build Bot 		no flags Details
updated patch (1.51 KB, patch)
2014-07-03 23:56 PDT, Daewoong Jang 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (642.90 KB, application/zip)
2014-07-04 01:07 PDT, Build Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daewoong Jang 2014-06-29 03:42:35 PDT 
Different combinations of CodeType and JSParserStrictness could generate same m_flags value because the value of CodeType and the value of JSParserStrictness shares a bit inside m_flags member variable.
Shift the value of CodeType one bit farther to the left so those values don't overlap.
Comment 1 Daewoong Jang 2014-06-29 03:45:02 PDT 
Created attachment 234059 [details]
patch
Comment 2 Build Bot 2014-07-01 23:30:24 PDT 
Comment on attachment 234059 [details]
patch

Attachment 234059 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5121769715269632

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 3 Build Bot 2014-07-01 23:30:29 PDT 
Created attachment 234242 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Daewoong Jang 2014-07-02 18:05:26 PDT 
Created attachment 234302 [details]
updated patch
Comment 5 Build Bot 2014-07-02 21:11:31 PDT 
Comment on attachment 234302 [details]
updated patch

Attachment 234302 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5749145654525952

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 6 Build Bot 2014-07-02 21:11:36 PDT 
Created attachment 234314 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Daewoong Jang 2014-07-03 23:56:56 PDT 
Created attachment 234391 [details]
updated patch
Comment 8 Build Bot 2014-07-04 01:07:30 PDT 
Comment on attachment 234391 [details]
updated patch

Attachment 234391 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5170155071995904

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 9 Build Bot 2014-07-04 01:07:38 PDT 
Created attachment 234392 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 10 WebKit Commit Bot 2014-07-06 19:07:01 PDT 
Comment on attachment 234391 [details]
updated patch

Clearing flags on attachment: 234391

Committed r170834: <http://trac.webkit.org/changeset/170834>
Comment 11 WebKit Commit Bot 2014-07-06 19:07:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Geoffrey Garen 2014-07-07 11:07:57 PDT 
Can you add a regression test for this?