Bug 134432 - [iOS][WK2] PDFs never load inline again after the Web process crashes
Summary: [iOS][WK2] PDFs never load inline again after the Web process crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-28 15:23 PDT by Tim Horton
Modified: 2014-06-28 15:40 PDT (History)
9 users (show)

See Also:


Attachments
patch (8.31 KB, patch)
2014-06-28 15:27 PDT, Tim Horton
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-06-28 15:23:29 PDT
Ship mimeTypesWithCustomRepresentations over in WebPageCreationParameters so that we have it after a crash.

<rdar://problem/17484205>
Comment 1 Tim Horton 2014-06-28 15:27:06 PDT
Created attachment 234054 [details]
patch
Comment 2 mitz 2014-06-28 15:31:11 PDT
Comment on attachment 234054 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234054&action=review

> Source/WebKit2/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:94
> +    for (auto& mimeType : _contentProviderForMIMEType.keys())
> +        mimeTypes.append(mimeType);

Can you use copyKeysToVector to do this?
Comment 3 Tim Horton 2014-06-28 15:33:19 PDT
Comment on attachment 234054 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234054&action=review

>> Source/WebKit2/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:94
>> +        mimeTypes.append(mimeType);
> 
> Can you use copyKeysToVector to do this?

ooh la la I've wanted that so many times and never knew it existed.
Comment 4 Tim Horton 2014-06-28 15:40:06 PDT
http://trac.webkit.org/changeset/170570