Bug 134431 - Remove redundant repaintCompositedLayers() parameter and its dependencies.
Summary: Remove redundant repaintCompositedLayers() parameter and its dependencies.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
Depends on:
Reported: 2014-06-28 14:20 PDT by zalan
Modified: 2014-06-30 11:07 PDT (History)
9 users (show)

See Also:

Patch (9.18 KB, patch)
2014-06-28 14:24 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-06-28 14:20:52 PDT
Surprisingly enough, only repaintCompositedLayers() calls recursiveRepaintLayer() and repaintCompositedLayers() passes NULL rect. It means that we never partially paint these layers.
Comment 1 zalan 2014-06-28 14:24:34 PDT
Created attachment 234052 [details]
Comment 2 Simon Fraser (smfr) 2014-06-28 16:38:10 PDT
This was certainly used at some point. What's the history of this code?
Comment 3 zalan 2014-06-28 18:00:25 PDT
FrameSelection code used to call repaintCompositedLayers() with a non NULL rect. That code got heavily refactored and now it calls ::repaintUsingContainer()
Comment 4 WebKit Commit Bot 2014-06-30 11:07:20 PDT
Comment on attachment 234052 [details]

Clearing flags on attachment: 234052

Committed r170590: <http://trac.webkit.org/changeset/170590>
Comment 5 WebKit Commit Bot 2014-06-30 11:07:25 PDT
All reviewed patches have been landed.  Closing bug.