Bug 134423 - [Win] Fix Leak in WebCore::createGlobalImageFileDescriptor
Summary: [Win] Fix Leak in WebCore::createGlobalImageFileDescriptor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-27 17:39 PDT by Brent Fulgham
Modified: 2014-07-22 12:37 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2014-06-27 17:41 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (4.95 KB, patch)
2014-06-27 18:07 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (4.99 KB, patch)
2014-06-30 10:51 PDT, Brent Fulgham 		ggaren: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (665.20 KB, application/zip)
2014-06-30 12:00 PDT, Build Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-06-27 17:39:32 PDT 
createGlobalImageFileDescriptor can leak a FILEGROUPDESCRIPTOR (HGLOBAL) in an error case..
Comment 1 Brent Fulgham 2014-06-27 17:39:44 PDT 
<rdar://problem/17492758>
Comment 2 Brent Fulgham 2014-06-27 17:41:33 PDT 
Created attachment 234035 [details]
Patch
Comment 3 Brent Fulgham 2014-06-27 18:07:35 PDT 
Created attachment 234036 [details]
Patch
Comment 4 Brent Fulgham 2014-06-27 18:08:50 PDT 
Fixed a few other things identified in the same file.
Comment 5 Brent Fulgham 2014-06-30 10:51:36 PDT 
Created attachment 234080 [details]
Patch
Comment 6 Geoffrey Garen 2014-06-30 11:24:31 PDT 
Comment on attachment 234080 [details]
Patch

r=me

When does this failure occur? Can you create a regression test for it?
Comment 7 Build Bot 2014-06-30 12:00:03 PDT 
Comment on attachment 234080 [details]
Patch

Attachment 234080 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4544576308117504

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 8 Build Bot 2014-06-30 12:00:08 PDT 
Created attachment 234085 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 9 Brent Fulgham 2014-07-22 12:37:26 PDT 
Committed r171353: <http://trac.webkit.org/changeset/171353>