Bug 134410 - InfoClick (from Nisus Software) dies on viewing found items
Summary: InfoClick (from Nisus Software) dies on viewing found items
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-27 13:59 PDT by Sam Weinig
Modified: 2014-06-27 17:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.87 KB, patch)
2014-06-27 14:02 PDT, Sam Weinig 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-06-27 13:59:28 PDT 
InfoClick (from Nisus Software) dies on viewing found items
Comment 1 Sam Weinig 2014-06-27 14:02:01 PDT 
Created attachment 234014 [details]
Patch
Comment 2 Sam Weinig 2014-06-27 14:05:01 PDT 
Committed revision 170552.
Comment 3 Andy Estes 2014-06-27 14:12:04 PDT 
Comment on attachment 234014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234014&action=review

> Source/WebKit/mac/ChangeLog:18
> +        (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
> +        Remove now unnecessary call to InitWebCoreSystemInterface().

Wait, why is this now unnecessary? +initialize doesn't call +_switchNetworkLoaderToNewTestingSession.
Comment 4 Sam Weinig 2014-06-27 17:31:24 PDT 
(In reply to comment #3)
> (From update of attachment 234014 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234014&action=review
> 
> > Source/WebKit/mac/ChangeLog:18
> > +        (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
> > +        Remove now unnecessary call to InitWebCoreSystemInterface().
> 
> Wait, why is this now unnecessary? +initialize doesn't call +_switchNetworkLoaderToNewTestingSession.

+initialize is guaranteed to be called will be called before +_switchNetworkLoaderToNewTestingSession by the runtime.