Bug 134395 - Add myself to contributors.json.
Summary: Add myself to contributors.json.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 134394 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-06-27 06:23 PDT by Sungmann Cho
Modified: 2014-06-27 11:56 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.08 KB, patch)
2014-06-27 06:24 PDT, Sungmann Cho
no flags Details | Formatted Diff | Diff
Patch (1.08 KB, patch)
2014-06-27 07:12 PDT, Sungmann Cho
ap: review-
ap: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sungmann Cho 2014-06-27 06:23:20 PDT
Add myself to contributors.json.
Comment 1 Sungmann Cho 2014-06-27 06:24:01 PDT
Created attachment 233979 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-27 06:26:48 PDT
Attachment 233979 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sungmann Cho 2014-06-27 06:29:41 PDT
*** Bug 134394 has been marked as a duplicate of this bug. ***
Comment 4 Csaba Osztrogonác 2014-06-27 07:03:35 PDT
Comment on attachment 233979 [details]
Patch

Please don't add yourself to the list of reviewers, but contributors.
Comment 5 Sungmann Cho 2014-06-27 07:12:44 PDT
Created attachment 233981 [details]
Patch
Comment 6 WebKit Commit Bot 2014-06-27 07:14:52 PDT
Attachment 233981 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Alexey Proskuryakov 2014-06-27 11:56:09 PDT
Comment on attachment 233981 [details]
Patch

> contributors.json should not be modified through the commit queue

Yes, what the bot said.

The purpose of contributor list is to enable Bugzilla autocomplete, so when a committer finds themselves CC'ing you on bugs often, they can add you to the list.