Bug 134390 - [GTK] Use public getter/setter in GObject DOM bindings properties implementation
Summary: [GTK] Use public getter/setter in GObject DOM bindings properties implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-06-27 03:19 PDT by Carlos Garcia Campos
Modified: 2014-06-28 02:06 PDT (History)
9 users (show)

See Also:


Attachments
Patch (65.39 KB, patch)
2014-06-27 14:53 PDT, Juan A. Suarez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (578.79 KB, application/zip)
2014-06-27 15:39 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-06-27 03:19:40 PDT
We are currently duplicating the code in the get/set_property methods and the public getter/setters, making both the code generator and the generated code more complicated.
Comment 1 Juan A. Suarez 2014-06-27 14:53:56 PDT
Created attachment 234020 [details]
Patch
Comment 2 Build Bot 2014-06-27 15:39:03 PDT
Comment on attachment 234020 [details]
Patch

Attachment 234020 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6534453446836224

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 3 Build Bot 2014-06-27 15:39:07 PDT
Created attachment 234028 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 WebKit Commit Bot 2014-06-28 02:06:39 PDT
Comment on attachment 234020 [details]
Patch

Clearing flags on attachment: 234020

Committed r170567: <http://trac.webkit.org/changeset/170567>
Comment 5 WebKit Commit Bot 2014-06-28 02:06:45 PDT
All reviewed patches have been landed.  Closing bug.