Bug 134381 – HIDGamepads should populate themselves with initial input values

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

HIDGamepads should populate themselves with initial input values.

At construction time, for each element they own they should query the HIDElement on the device.

[Brady Eidson]

Created attachment 233961 [details]
Patch v1

[Brady Eidson]

Created attachment 233962 [details]
Patch v2 - Now with 100% more ChangeLog

[Brady Eidson]

Ignore the can't-buildness that EWS sees - In my tree this patch is built on previous patches.  I will pass it through EWS before landing.

[Darin Adler]

Comment on attachment 233962 [details]
Patch v2 - Now with 100% more ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=233962&action=review

Patch didn’t apply in EWS.

> Source/WebCore/platform/mac/HIDGamepad.cpp:75
> +    IOHIDValueRef value;

I think a local just before each call to IOHIDDeviceGetValue would be nicer than sharing this local.

> Source/WebCore/platform/mac/HIDGamepad.cpp:79
> +        IOHIDElementRef element = button->iohidElement.get();
> +        if (IOHIDDeviceGetValue(IOHIDElementGetDevice(element), element, &value) == kIOReturnSuccess)
> +            valueChanged(value);

I know this sounds a little silly, but a helper that takes an const HIDGamepadElement& and does all this would make the code tigther and easier to read.

> Source/WebCore/platform/mac/HIDGamepad.h:80
>  struct HIDGamepadAxis : public HIDGamepadElement {

Normally with struct inheritance we would omit the "public" (it's the default).

[Brady Eidson]

http://trac.webkit.org/changeset/170551