Bug 134364 - DOM attributes on prototypes should be configurable
Summary: DOM attributes on prototypes should be configurable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Dumez
URL: https://heycam.github.io/webidl/#es-a...
Keywords:
Depends on:
Blocks: 142934 149465
  Show dependency treegraph
 
Reported: 2014-06-26 14:54 PDT by Mark Hahnenberg
Modified: 2016-01-28 14:40 PST (History)
8 users (show)

See Also:


Attachments
Patch (57.97 KB, patch)
2015-09-21 14:42 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (1.09 MB, application/zip)
2015-09-21 15:23 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (1.14 MB, application/zip)
2015-09-21 15:26 PDT, Build Bot
no flags Details
Patch (55.43 KB, patch)
2015-09-21 16:14 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (55.48 KB, patch)
2015-09-21 16:20 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (55.62 KB, patch)
2015-09-21 21:48 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-06-26 14:54:27 PDT
Currently they're not due to the internal implementation of CustomGetters/CustomSetters vs. normal Getters/Setters. Allowing mixing of Custom and non-Custom Getters and Setters in the same slot will enable attributes on the prototype to be configurable.
Comment 1 Chris Dumez 2015-09-21 14:42:52 PDT
Created attachment 261685 [details]
Patch
Comment 2 Build Bot 2015-09-21 15:23:36 PDT
Comment on attachment 261685 [details]
Patch

Attachment 261685 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/194514

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.delete.html
js/dom/getOwnPropertyDescriptor.html
js/dom/global-constructors-attributes.html
imported/w3c/canvas/2d.type.delete.html
js/dom/global-constructors-deletable.html
js/dom/global-constructors-attributes-dedicated-worker.html
imported/w3c/web-platform-tests/dom/interface-objects.html
js/dom/global-constructors-attributes-idb.html
imported/w3c/web-platform-tests/dom/interfaces.html
imported/w3c/web-platform-tests/html/dom/interfaces.html
imported/w3c/canvas/type.delete.html
Comment 3 Build Bot 2015-09-21 15:23:40 PDT
Created attachment 261689 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-09-21 15:26:46 PDT
Comment on attachment 261685 [details]
Patch

Attachment 261685 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/194515

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.delete.html
js/dom/getOwnPropertyDescriptor.html
js/dom/global-constructors-attributes.html
imported/w3c/canvas/2d.type.delete.html
js/dom/global-constructors-attributes-dedicated-worker.html
js/dom/global-constructors-deletable.html
imported/w3c/web-platform-tests/dom/interface-objects.html
js/dom/global-constructors-attributes-idb.html
imported/w3c/web-platform-tests/dom/interfaces.html
imported/w3c/web-platform-tests/html/dom/interfaces.html
imported/w3c/canvas/type.delete.html
Comment 5 Build Bot 2015-09-21 15:26:50 PDT
Created attachment 261690 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Chris Dumez 2015-09-21 16:14:31 PDT
Created attachment 261699 [details]
Patch
Comment 7 Chris Dumez 2015-09-21 16:20:32 PDT
Created attachment 261700 [details]
Patch
Comment 8 Sam Weinig 2015-09-21 20:07:03 PDT
Comment on attachment 261700 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261700&action=review

> LayoutTests/fast/dom/attributes-configurable.html:10
> +shouldBeTrue("event.__proto__.hasOwnProperty('eventPhase')");

Seems useful to also have a test that checks the result of Object.getOwnPropertyDescriptor. (something like, Object.getOwnPropertyDescriptor(event.__proto__, "eventPhase").configurable).
Comment 9 Chris Dumez 2015-09-21 20:22:30 PDT
Comment on attachment 261700 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261700&action=review

>> LayoutTests/fast/dom/attributes-configurable.html:10
>> +shouldBeTrue("event.__proto__.hasOwnProperty('eventPhase')");
> 
> Seems useful to also have a test that checks the result of Object.getOwnPropertyDescriptor. (something like, Object.getOwnPropertyDescriptor(event.__proto__, "eventPhase").configurable).

Right, will do. Thanks.
Comment 10 Chris Dumez 2015-09-21 21:48:21 PDT
Created attachment 261721 [details]
Patch
Comment 11 WebKit Commit Bot 2015-09-21 22:37:12 PDT
Comment on attachment 261721 [details]
Patch

Clearing flags on attachment: 261721

Committed r190104: <http://trac.webkit.org/changeset/190104>
Comment 12 WebKit Commit Bot 2015-09-21 22:37:18 PDT
All reviewed patches have been landed.  Closing bug.