RESOLVED FIXED 134352
[MSE] Refactoring: Use C++11 for-loops in SourceBuffer. 
https://bugs.webkit.org/show_bug.cgi?id=134352
Summary [MSE] Refactoring: Use C++11 for-loops in SourceBuffer.
Jer Noble
Reported 2014-06-26 11:21:48 PDT
[MSE] Refactoring: Use C++11 for-loops in SourceBuffer.
Attachments
Patch (13.61 KB, patch)
2014-06-26 11:28 PDT, Jer Noble 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-06-26 11:28:18 PDT
Created attachment 233918 [details] Patch
Darin Adler
Comment 2 2014-06-26 11:35:57 PDT
Comment on attachment 233918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233918&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:316 > + AtomicString trackID = trackBufferPair.key; Wasting a little performance here by using AtomicString instead of const AtomicString& or auto&.
Jer Noble
Comment 3 2014-06-26 11:45:17 PDT
(In reply to comment #2) > (From update of attachment 233918 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233918&action=review > > > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:316 > > + AtomicString trackID = trackBufferPair.key; > > Wasting a little performance here by using AtomicString instead of const AtomicString& or auto&. Good point. Will fix that (as well as a compilation error) before landing.
Jer Noble
Comment 4 2014-06-26 11:50:57 PDT
Committed r170488: <http://trac.webkit.org/changeset/170488>
Note You need to log in before you can comment on or make changes to this bug.