Bug 134352 - [MSE] Refactoring: Use C++11 for-loops in SourceBuffer.
Summary: [MSE] Refactoring: Use C++11 for-loops in SourceBuffer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-26 11:21 PDT by Jer Noble
Modified: 2014-06-27 00:30 PDT (History)
10 users (show)

See Also:


Attachments
Patch (13.61 KB, patch)
2014-06-26 11:28 PDT, Jer Noble
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-06-26 11:21:48 PDT
[MSE] Refactoring: Use C++11 for-loops in SourceBuffer.
Comment 1 Jer Noble 2014-06-26 11:28:18 PDT
Created attachment 233918 [details]
Patch
Comment 2 Darin Adler 2014-06-26 11:35:57 PDT
Comment on attachment 233918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233918&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:316
> +        AtomicString trackID = trackBufferPair.key;

Wasting a little performance here by using AtomicString instead of const AtomicString& or auto&.
Comment 3 Jer Noble 2014-06-26 11:45:17 PDT
(In reply to comment #2)
> (From update of attachment 233918 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233918&action=review
> 
> > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:316
> > +        AtomicString trackID = trackBufferPair.key;
> 
> Wasting a little performance here by using AtomicString instead of const AtomicString& or auto&.

Good point.  Will fix that (as well as a compilation error) before landing.
Comment 4 Jer Noble 2014-06-26 11:50:57 PDT
Committed r170488: <http://trac.webkit.org/changeset/170488>