RESOLVED FIXED 134350
[iOS] no need to deactivate audio session 
https://bugs.webkit.org/show_bug.cgi?id=134350
Summary [iOS] no need to deactivate audio session
Eric Carlson
Reported 2014-06-26 10:37:46 PDT
There is no need to call setActive:NO on the audio session, WebCore's session will automatically be deactivated if another application begins playing audio.
Attachments
Proposed patch. (1.24 KB, patch)
2014-06-26 11:00 PDT, Eric Carlson 		jer.noble: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-06-26 10:38:36 PDT
<rdar://problem/16853657>
Eric Carlson
Comment 2 2014-06-26 11:00:41 PDT
Created attachment 233916 [details] Proposed patch.
Jer Noble
Comment 3 2014-06-26 11:02:32 PDT
Comment on attachment 233916 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=233916&action=review r=me > Source/WebCore/ChangeLog:9 > + [iOS] no need to deactivate audio session > + https://bugs.webkit.org/show_bug.cgi?id=134350 > + > + Reviewed by NOBODY (OOPS!). > + > + * platform/audio/mac/MediaSessionManagerMac.cpp: > + (MediaSessionManager::updateSessionState): Never call setActive:false. nit: Why not? (Maybe: "Embedding WebView apps may want to enable the audio session outside of the WebView, and since the AudioSession is global to the app, disabling the audio session can interrupt that audio."
Eric Carlson
Comment 4 2014-06-26 11:31:29 PDT
Committed r170485: https://trac.webkit.org/r170485
Note You need to log in before you can comment on or make changes to this bug.