Bug 134347 - Define TARGET_OS_IPHONE to 0 for non-darwin ports
Summary: Define TARGET_OS_IPHONE to 0 for non-darwin ports
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-06-26 09:00 PDT by Laszlo Gombos
Modified: 2014-06-26 15:19 PDT (History)
8 users (show)

See Also:

It reads slightly better.. (1.20 KB, patch)
2014-06-26 09:08 PDT, Laszlo Gombos
darin: review+
Details | Formatted Diff | Diff
for cq incorporating Darin's feedback (1.20 KB, patch)
2014-06-26 14:39 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2014-06-26 09:00:38 PDT
Follow-up for http://trac.webkit.org/changeset/169880 to make it a bit more future proof and easier to read and reason about it.
Comment 1 Laszlo Gombos 2014-06-26 09:08:40 PDT
Created attachment 233904 [details]
It reads slightly better..
Comment 2 Darin Adler 2014-06-26 11:39:38 PDT
Comment on attachment 233904 [details]
It reads slightly better..

View in context: https://bugs.webkit.org/attachment.cgi?id=233904&action=review

It’s worth noting why this is different from our usual strategy. Unlike, say, WebCore, WebKit2 has public header files, and in public header files we need to use conditionals that don’t rely on WebKit internals such as Platform.h.

Understanding that leads to the thought that for EFL and GTK, this use of TARGET_OS_IPHONE in public header files might pose a problem, for the same reason that PLATFORM(IOS) would be a problem on the Mac and iOS platform. We may need to run a script to strip those out for those platforms as part of the “installing public headers” process.

> Source/WTF/wtf/Platform.h:1049
> +/* Set TARGET_OS_IPHONE to 0 by default to allow using it as a guard 
> + * in cross-platform the same way as it is used in OS(DARWIN) code */ 

Normally we’d put a period at the end of a sentence.
Comment 3 Laszlo Gombos 2014-06-26 14:39:32 PDT
Created attachment 233934 [details]
for cq incorporating Darin's feedback
Comment 4 WebKit Commit Bot 2014-06-26 15:19:22 PDT
Comment on attachment 233934 [details]
for cq incorporating Darin's feedback

Clearing flags on attachment: 233934

Committed r170498: <http://trac.webkit.org/changeset/170498>
Comment 5 WebKit Commit Bot 2014-06-26 15:19:27 PDT
All reviewed patches have been landed.  Closing bug.