Bug 134345 – Fix Debug Build Error in Webcore module

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Shivakumar J M]

Found Build Error in WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp during webkit-efl port debug build.

from /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp:31:
/home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp: In member function ‘void WebCore::HarfBuzzShaper::setDrawRange(int, int)’:
/home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp:335:57: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
     ASSERT_WITH_SECURITY_IMPLICATION(to <= m_run.length());
                                                         ^
/home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WTF/wtf/Assertions.h:268:8: note: in definition of macro ‘ASSERT_WITH_SECURITY_IMPLICATION’
     (!(assertion) ? \
        ^
[ 68%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/texmap/coordinated/AreaAllocator.cpp.o

[Shivakumar J M]

Created attachment 233898 [details]
Patch

Use static cast to change the type of variable to fix error

[WebKit Commit Bot]

Attachment 233898 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Shivakumar J M]

Created attachment 233900 [details]
Patch-Updated

Updated the patch since no tests are needed

[zalan]

Comment on attachment 233900 [details]
Patch-Updated

I'd rather have both 'from' and 'to' unsigned, but this is good for now to get the build fixed.

[WebKit Commit Bot]

Comment on attachment 233900 [details]
Patch-Updated

Clearing flags on attachment: 233900

Committed r170479: <http://trac.webkit.org/changeset/170479>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.