Bug 134337 - HIDGamepad should use CFIndex when looping
Summary: HIDGamepad should use CFIndex when looping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-25 22:42 PDT by Dean Jackson
Modified: 2014-09-12 16:54 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2014-06-25 22:45 PDT, Dean Jackson
mitz: review+
Details | Formatted Diff | Diff
Patch (1.42 KB, patch)
2014-06-25 22:55 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-06-25 22:42:57 PDT
HIDGamepad should use CFIndex when looping
Comment 1 Dean Jackson 2014-06-25 22:45:46 PDT
Created attachment 233884 [details]
Patch
Comment 2 mitz 2014-06-25 22:48:14 PDT
Comment on attachment 233884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233884&action=review

> Source/WebCore/platform/mac/HIDGamepad.cpp:79
> +    CFIndex count = CFArrayGetCount(elements);
> +    for (CFIndex i = 0; i < count; ++i) {

Our usual style for this is for (CFIndex i = 0, count = CFArrayGetCount(elements); i < count; ++i)
Comment 3 Dean Jackson 2014-06-25 22:55:43 PDT
Created attachment 233887 [details]
Patch
Comment 4 WebKit Commit Bot 2014-06-25 23:35:48 PDT
Comment on attachment 233887 [details]
Patch

Clearing flags on attachment: 233887

Committed r170469: <http://trac.webkit.org/changeset/170469>