Created attachment 233883 [details] test case test case: expected a dashed or dotted underline actual: a solid underline The Webkit inspector does seem to accept the values as valid / supported. All other text-decoration-style values are supported and rendered correctly.
<rdar://problem/26613669>
I can't figure out how this ever worked. We set the stroke style ever since r132076, but we've been filling the underline instead of stroking it since r23761. (So setting the stroke style is irrelevant.)
Created attachment 280746 [details] Patch
Comment on attachment 280746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280746&action=review > Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1518 > + float particleWidth = 0; > + switch (strokeStyle) { > + case DottedStroke: > + particleWidth = bounds.height(); > + break; > + case DashedStroke: > + particleWidth = 2 * bounds.height(); I think this should be dashWidth. > LayoutTests/ChangeLog:15 > + * fast/css3-text/css3-text-decoration/text-decoration-dashed-expected-mismatch.html: Added. > + * fast/css3-text/css3-text-decoration/text-decoration-dashed.html: Added. > + * fast/css3-text/css3-text-decoration/text-decoration-dotted-dashed-expected-mismatch.html: Added. > + * fast/css3-text/css3-text-decoration/text-decoration-dotted-dashed.html: Added. > + * fast/css3-text/css3-text-decoration/text-decoration-dotted-expected-mismatch.html: Added. > + * fast/css3-text/css3-text-decoration/text-decoration-dotted.html: Added. It's a shame we can't produce actual results to test against.
Committed r201777: <http://trac.webkit.org/changeset/201777>
Note these layout tests are flaky on GTK, see bug #158918.