Bug 134322 - After r170428, offline assembler sometimes creates empty LLIntAssembly.h
Summary: After r170428, offline assembler sometimes creates empty LLIntAssembly.h
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-25 18:09 PDT by Michael Saboff
Modified: 2014-06-26 17:32 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-06-25 18:09:49 PDT 
After r170428, the offline assembler will sometimes create an LLIntAssembly.h file with just the hash line:
// offlineasm input hash: cb3be4a5c6bc8076a46396599fba7c070d00cdf8 1fdc12e5c4851899db57a32e840ba77f46a9fa29 283b8172f1ff6e5e115dbe22d5c7494f289ea2da
Comment 1 peavo 2014-06-26 09:48:25 PDT 
This is just a guess, but could it be caused by an exception being thrown,
caused by for example the change in asm.rb?


--- Source/JavaScriptCore/offlineasm/asm.rb	(revision 170426)
+++ Source/JavaScriptCore/offlineasm/asm.rb	(working copy)
@@ -262,7 +262,7 @@ class Assembler
             @codeOrigin = nil
             @commentState = :many
         when :many
-            @outp.puts "// #{text}" if $enableCodeOriginComments
+            @outp.puts $commentPrefix + " #{text}" if $enableCodeOriginComments
         else
             raise
         end
Comment 2 Michael Saboff 2014-06-26 17:32:57 PDT 
I can no longer get this to fail.  When I filed, I performed the following steps:

svn up -r 170424
Tools/Scripts/build-webkit --debug
svn up -r 170431
Tools/Scripts/build-webkit --debug

The second build failed.

Today, those steps work fine.  I tried multiple times, but can't reproduce.

We can file another bug if the problem reappears.