Bug 134318 - [Win] Expose Cache Information to WinLauncher
Summary: [Win] Expose Cache Information to WinLauncher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-25 17:14 PDT by Brent Fulgham
Modified: 2014-06-26 10:22 PDT (History)
8 users (show)

See Also:

Attachments
Patch (54.69 KB, patch)
2014-06-25 17:43 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (38.76 KB, patch)
2014-06-26 09:15 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (40.30 KB, patch)
2014-06-26 09:18 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (54.69 KB, patch)
2014-06-26 09:21 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (50.03 KB, patch)
2014-06-26 09:56 PDT, Brent Fulgham 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-06-25 17:14:32 PDT 
It would be useful to be able to see information about memory use and cache status of various objects in WebKit.

This patch exposes the contents of our IWebCache and IWebCoreStatistics interfaces to the WinLauncher UI to make it easier to see this information.
Comment 1 Brent Fulgham 2014-06-25 17:43:58 PDT 
Created attachment 233858 [details]
Patch
Comment 2 Brent Fulgham 2014-06-26 09:15:21 PDT 
Created attachment 233906 [details]
Patch
Comment 3 Brent Fulgham 2014-06-26 09:18:58 PDT 
Created attachment 233907 [details]
Patch
Comment 4 Brent Fulgham 2014-06-26 09:20:33 PDT 
EWS bots are being difficult!
Comment 5 Brent Fulgham 2014-06-26 09:21:28 PDT 
Created attachment 233908 [details]
Patch
Comment 6 Brent Fulgham 2014-06-26 09:56:43 PDT 
Created attachment 233910 [details]
Patch
Comment 7 Brent Fulgham 2014-06-26 09:57:34 PDT 
Looks like EOL-foo was confusing the bots. I landed a separate fix for the multiple EOL-styles in WinLauncher.h. Hopefully that will allow this patch to be processed successfully.
Comment 8 Dean Jackson 2014-06-26 10:09:07 PDT 
Comment on attachment 233910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233910&action=review

rs=me

> Source/WebKit/win/WebCache.cpp:113
> +    // Counts

Nit: Missing period here and on the other new comments.
Comment 9 Brent Fulgham 2014-06-26 10:22:37 PDT 
Committed r170483: <http://trac.webkit.org/changeset/170483>