Bug 134315 - Web process should become active when sent a message that requires a callback
Summary: Web process should become active when sent a message that requires a callback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-25 16:32 PDT by mitz
Modified: 2014-06-25 17:53 PDT (History)
7 users (show)

See Also:


Attachments
Make callbacks hold on to an activity token (75.49 KB, patch)
2014-06-25 16:47 PDT, mitz
thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (1009.06 KB, application/zip)
2014-06-25 17:43 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-06-25 16:32:21 PDT
Web process should become active when sent a message that requires a callback
Comment 1 mitz 2014-06-25 16:47:09 PDT
Created attachment 233849 [details]
Make callbacks hold on to an activity token
Comment 2 WebKit Commit Bot 2014-06-25 16:48:45 PDT
Attachment 233849 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/GenericCallback.h:193:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:60:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2014-06-25 17:43:25 PDT
Comment on attachment 233849 [details]
Make callbacks hold on to an activity token

Attachment 233849 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4657953244184576

New failing tests:
http/tests/navigation/success200-goback.html
http/tests/navigation/redirect302-goback.html
http/tests/navigation/postredirect-goback1.html
http/tests/navigation/post-goback-same-url.html
http/tests/navigation/postredirect-reload.html
http/tests/navigation/relativeanchor-goback.html
http/tests/navigation/success200-reload.html
http/tests/navigation/javascriptlink-goback.html
http/tests/navigation/postredirect-basic.html
http/tests/navigation/forward-and-cancel.html
http/tests/navigation/post-goback2.html
http/tests/navigation/timerredirect-goback.html
http/tests/navigation/restore-form-state-https.html
http/tests/navigation/anchor-goback.html
http/tests/navigation/success200-frames-loadsame.html
http/tests/navigation/relativeanchor-basic.html
http/tests/navigation/postredirect-frames.html
http/tests/navigation/metaredirect-goback.html
http/tests/navigation/error404-goback.html
http/tests/navigation/postredirect-goback2.html
http/tests/navigation/success200-loadsame.html
Comment 4 Build Bot 2014-06-25 17:43:28 PDT
Created attachment 233857 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 mitz 2014-06-25 17:53:33 PDT
(In reply to comment #4)
> Created an attachment (id=233857) [details]
> Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
> Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

This should be fixed with http://trac.webkit.org/r170452.