RESOLVED FIXED 134307
Structure bit fields should have a consistent format 
https://bugs.webkit.org/show_bug.cgi?id=134307
Summary Structure bit fields should have a consistent format
Mark Hahnenberg
Reported 2014-06-25 13:40:31 PDT
Currently we use C-style bit fields for a number of member variables in Structure to save space. This makes it difficult to load these fields in the JIT. We should instead use our own bitfield format to make it easy to load and test these variables in JIT code.
Attachments
Patch (30.21 KB, patch)
2014-06-25 13:43 PDT, Mark Hahnenberg 		fpizlo: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-06-25 13:43:00 PDT
Created attachment 233834 [details] Patch
WebKit Commit Bot
Comment 2 2014-06-25 14:05:11 PDT
Comment on attachment 233834 [details] Patch Rejecting attachment 233834 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 233834, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ded at 479 (offset 8 lines). Hunk #11 succeeded at 498 (offset 8 lines). Hunk #12 FAILED at 549. 4 out of 12 hunks FAILED -- saving rejects to file Source/JavaScriptCore/runtime/Structure.h.rej patching file Source/JavaScriptCore/runtime/StructureInlines.h Hunk #1 succeeded at 154 (offset 19 lines). Hunk #2 succeeded at 247 (offset 19 lines). Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5064153534300160
Mark Hahnenberg
Comment 3 2014-06-25 14:18:57 PDT
Landed on the branch in http://trac.webkit.org/changeset/170436
Note You need to log in before you can comment on or make changes to this bug.