RESOLVED FIXED 134300
[GTK] Expose getter and setter functions for attributes named type
https://bugs.webkit.org/show_bug.cgi?id=134300
Summary [GTK] Expose getter and setter functions for attributes named type
Carlos Garcia Campos
Reported 2014-06-25 09:06:25 PDT
We skip those because the getter conflicts with the get_type() function of all GObjects. We can use a different name for them. As a general rule we can use the last word of the class name, something like: webkit_dom_blob_get_type() -> webkit_dom_blob_get_blob_type() webkit_dom_event_get_type() -> webkit_dom_event_get_event_type() That's consistent with other existing DOM methods like webkit_dom_xpath_result_get_result_type() or webkit_dom_css_value_get_css_value_type(). We would still need to add some exceptions, but they are not that much in the end.
Attachments
Patch (16.13 KB, patch)
2014-06-25 09:14 PDT, Carlos Garcia Campos
no flags
Updated patch (16.67 KB, patch)
2014-06-26 01:31 PDT, Carlos Garcia Campos
mrobinson: review+
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (609.37 KB, application/zip)
2014-06-26 02:33 PDT, Build Bot
no flags
Carlos Garcia Campos
Comment 1 2014-06-25 09:14:28 PDT
Created attachment 233819 [details] Patch We should also expose the constants used by some of those new methods when bug #133983 is fixed.
Carlos Garcia Campos
Comment 2 2014-06-26 01:31:39 PDT
Created attachment 233893 [details] Updated patch Updated to add the constants needed by some get_type methods to the public symbols list now that we support constants.
Build Bot
Comment 3 2014-06-26 02:33:31 PDT
Comment on attachment 233893 [details] Updated patch Attachment 233893 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5827650274721792 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Build Bot
Comment 4 2014-06-26 02:33:36 PDT
Created attachment 233897 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Martin Robinson
Comment 5 2014-06-26 15:59:27 PDT
Comment on attachment 233893 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=233893&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:971 > +sub GetFunctionSigName { Sig->Signature > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1021 > + my $functionSigName = GetFunctionSigName($interfaceName, $function); Ditto.
Carlos Garcia Campos
Comment 6 2014-06-27 00:28:01 PDT
Note You need to log in before you can comment on or make changes to this bug.