Bug 134300 - [GTK] Expose getter and setter functions for attributes named type
Summary: [GTK] Expose getter and setter functions for attributes named type
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Blocks: 133724
  Show dependency treegraph
Reported: 2014-06-25 09:06 PDT by Carlos Garcia Campos
Modified: 2014-06-27 00:28 PDT (History)
9 users (show)

See Also:

Patch (16.13 KB, patch)
2014-06-25 09:14 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated patch (16.67 KB, patch)
2014-06-26 01:31 PDT, Carlos Garcia Campos
mrobinson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (609.37 KB, application/zip)
2014-06-26 02:33 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-06-25 09:06:25 PDT
We skip those because the getter conflicts with the get_type() function of all GObjects. We can use a different name for them. As a general rule we can use the last word of the class name, something like:

webkit_dom_blob_get_type() -> webkit_dom_blob_get_blob_type()
webkit_dom_event_get_type() -> webkit_dom_event_get_event_type()

That's consistent with other existing DOM methods like webkit_dom_xpath_result_get_result_type() or webkit_dom_css_value_get_css_value_type().

We would still need to add some exceptions, but they are not that much in the end.
Comment 1 Carlos Garcia Campos 2014-06-25 09:14:28 PDT
Created attachment 233819 [details]

We should also expose the constants used by some of those new methods when bug #133983 is fixed.
Comment 2 Carlos Garcia Campos 2014-06-26 01:31:39 PDT
Created attachment 233893 [details]
Updated patch

Updated to add the constants needed by some get_type methods to the public symbols list now that we support constants.
Comment 3 Build Bot 2014-06-26 02:33:31 PDT
Comment on attachment 233893 [details]
Updated patch

Attachment 233893 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5827650274721792

New failing tests:
Comment 4 Build Bot 2014-06-26 02:33:36 PDT
Created attachment 233897 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Martin Robinson 2014-06-26 15:59:27 PDT
Comment on attachment 233893 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233893&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:971
> +sub GetFunctionSigName {


> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1021
> +    my $functionSigName = GetFunctionSigName($interfaceName, $function);

Comment 6 Carlos Garcia Campos 2014-06-27 00:28:01 PDT
Committed r170524: <http://trac.webkit.org/changeset/170524>