Bug 134299 - REGRESSION (r170426) Broke two python unit tests
Summary: REGRESSION (r170426) Broke two python unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michal Pakula vel Rutka
URL:
Keywords:
Depends on:
Blocks: 134195
  Show dependency treegraph
 
Reported: 2014-06-25 07:51 PDT by Michal Pakula vel Rutka
Modified: 2014-06-25 08:09 PDT (History)
8 users (show)

See Also:


Attachments
patch (1.08 KB, patch)
2014-06-25 07:53 PDT, Michal Pakula vel Rutka
ossy: review+
ossy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2014-06-25 07:51:48 PDT
SSIA
Comment 1 Michal Pakula vel Rutka 2014-06-25 07:53:40 PDT
Created attachment 233812 [details]
patch
Comment 2 WebKit Commit Bot 2014-06-25 07:54:46 PDT
Attachment 233812 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/port/efl.py:113:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Csaba Osztrogonác 2014-06-25 08:07:28 PDT
Comment on attachment 233812 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233812&action=review

r=me

> Tools/Scripts/webkitpy/port/efl.py:113
> +        search_paths.append(self.port_name + '-wk2');

Please remove the extra semicolon before landing.
Comment 4 Michal Pakula vel Rutka 2014-06-25 08:09:51 PDT
Committed r170427: <http://trac.webkit.org/changeset/170427>