Bug 134293 – [Mac] Update the time base of event's timestamp when the system time changes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

[Mac] Update the time base of event's timestamp when the system time changes

[Benjamin Poulain]

Created attachment 233793 [details]
Patch

[WebKit Commit Bot]

Attachment 233793 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:332:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:332:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:338:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:339:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:340:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 5 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 233793 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233793&action=review

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:332
> +        void (^updateBlock)(NSNotification *) = Block_copy(^(NSNotification *){ updateSystemStartupTimeIntervalSince1970(); });

There's no need to copy the block, it will be copied by addObserverForName. I'd just use a lambda instead of a block too (they're implicitly converted to blocks, so something like):

auto updateBlock = [](NSNotification *) { updateSystemStartupTimeIntervalSince1970(); };

[Benjamin Poulain]

(In reply to comment #3)
> (From update of attachment 233793 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233793&action=review
> 
> > Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:332
> > +        void (^updateBlock)(NSNotification *) = Block_copy(^(NSNotification *){ updateSystemStartupTimeIntervalSince1970(); });
> 
> There's no need to copy the block, it will be copied by addObserverForName. I'd just use a lambda instead of a block too (they're implicitly converted to blocks, so something like):

The reason I did that is to avoid having the block copied twice with 2 separate heap allocation.

[Benjamin Poulain]

Comment on attachment 233793 [details]
Patch

Clearing flags on attachment: 233793

Committed r170434: <http://trac.webkit.org/changeset/170434>

[Benjamin Poulain]

All reviewed patches have been landed.  Closing bug.