Bug 134286 - [iOS][WK2] Rotating a zoomed PDF leads to weird scrolling behavior
Summary: [iOS][WK2] Rotating a zoomed PDF leads to weird scrolling behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-24 18:49 PDT by Tim Horton
Modified: 2014-06-25 14:43 PDT (History)
8 users (show)

See Also:

Attachments
patch (2.88 KB, patch)
2014-06-24 18:56 PDT, Tim Horton 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-06-24 18:49:43 PDT 
The root view bounds and contentSize need to be scaled :|
Comment 1 Radar WebKit Bug Importer 2014-06-24 18:50:41 PDT 
<rdar://problem/17445835>
Comment 2 Tim Horton 2014-06-24 18:56:43 PDT 
Created attachment 233775 [details]
patch
Comment 3 Benjamin Poulain 2014-06-24 19:49:37 PDT 
Comment on attachment 233775 [details]
patch

Updating the frame to account for the scale makes sense.

But updating this on scroll make no absolutely no sense to me.
Comment 4 Tim Horton 2014-06-24 21:09:50 PDT 
(In reply to comment #3)
> (From update of attachment 233775 [details])
> Updating the frame to account for the scale makes sense.
> 
> But updating this on scroll make no absolutely no sense to me.

It ... isn't updated on scroll. Only web_setContentProviderData and web_setMinimumSize call _computePageAndDocumentFrames. Maybe you're thinking of _revalidateViews? Or I'm missing something?
Comment 5 Tim Horton 2014-06-25 14:43:48 PDT 
http://trac.webkit.org/changeset/170439