Bug 134267 - iOS WebKit2: block selection tends to prefer block to single words even when the page is zoomed.
Summary: iOS WebKit2: block selection tends to prefer block to single words even when ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-24 13:21 PDT by Enrica Casucci
Modified: 2014-06-24 13:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2014-06-24 13:27 PDT, Enrica Casucci 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-06-24 13:21:42 PDT 
This is easily reproduced on pages like reddit.com, browsing through the comments, zooming the page and trying to select a word.

<rdar://problem/17138059>
Comment 1 Enrica Casucci 2014-06-24 13:27:44 PDT 
Created attachment 233734 [details]
Patch
Comment 2 Benjamin Poulain 2014-06-24 13:33:11 PDT 
Comment on attachment 233734 [details]
Patch

The change makes sense. I would create a second rect (a FloatRect) especially for that purpose. Something like:
    FloatRect boundingRectInScrollViewCoordinates(boundingRect);
    boundingRectInScrollViewCoordinates.scale(...).

To make it explicit which that rect is not in document coordinates.
Comment 3 Enrica Casucci 2014-06-24 13:45:33 PDT 
Committed revision 170388.