Bug 134264 – [XHR] open method must uppercase only standard method types

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mahesh Kulkarni]

[XHR] open method must uppercase only standard method types

[Mahesh Kulkarni]

Created attachment 233731 [details]
Patch

[Mahesh Kulkarni]

Now all desktop browsers IE11, Mozilla 31, Chrome (dev m37) supports capitalizing only standard method names as per spec http://xhr.spec.whatwg.org/#the-open()-method.

[Mahesh Kulkarni]

(In reply to comment #2)
> Now all desktop browsers IE11, Mozilla 31, Chrome (dev m37) supports capitalizing only standard method names as per spec http://xhr.spec.whatwg.org/#the-open()-method.

This change will also pass all failing tests from w3c-test suite
http://w3c-test.org/XMLHttpRequest/open-method-case-sensitive.htm.

[Alexey Proskuryakov]

Comment on attachment 233731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233731&action=review

> Source/WebCore/xml/XMLHttpRequest.cpp:-397
> -    const char* const methods[] = { "COPY", "DELETE", "GET", "HEAD", "INDEX", "LOCK", "M-POST", "MKCOL", "MOVE", "OPTIONS", "POST", "PROPFIND", "PROPPATCH", "PUT", "UNLOCK" };

Is there test coverage for common methods whose handling changes here (eg propfind)?

[Mahesh Kulkarni]

(In reply to comment #4)
> (From update of attachment 233731 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233731&action=review
> 
> > Source/WebCore/xml/XMLHttpRequest.cpp:-397
> > -    const char* const methods[] = { "COPY", "DELETE", "GET", "HEAD", "INDEX", "LOCK", "M-POST", "MKCOL", "MOVE", "OPTIONS", "POST", "PROPFIND", "PROPPATCH", "PUT", "UNLOCK" };
> 
> Is there test coverage for common methods whose handling changes here (eg propfind)?

I did not find any for non-standard type method names.

[Build Bot]

Comment on attachment 233731 [details]
Patch

Attachment 233731 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6292203869569024

New failing tests:
media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_1.html
http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive.html
http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html

[Build Bot]

Created attachment 233770 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Mahesh Kulkarni]

mac-w2 seems red because of flaky test.

[Alexey Proskuryakov]

Are you sure? These failures seem related to the patch:

http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive.html
http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html

[Mahesh Kulkarni]

Created attachment 233905 [details]
Patch

[Build Bot]

Comment on attachment 233905 [details]
Patch

Attachment 233905 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5775701303099392

New failing tests:
http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive.html
http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html

[Build Bot]

Created attachment 233912 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 233905 [details]
Patch

Attachment 233905 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4607389642784768

New failing tests:
media/W3C/video/readyState/readyState_during_canplay.html
http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive.html
http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html

[Build Bot]

Created attachment 233917 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 233905 [details]
Patch

Attachment 233905 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6539798508470272

New failing tests:
http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive.html
http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html

[Build Bot]

Created attachment 233919 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Mahesh Kulkarni]

Created attachment 233925 [details]
Patch

[Mahesh Kulkarni]

Comment on attachment 233925 [details]
Patch

Thanks Darin!

[WebKit Commit Bot]

Comment on attachment 233925 [details]
Patch

Clearing flags on attachment: 233925

Committed r170530: <http://trac.webkit.org/changeset/170530>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.