Bug 134262 – Add long-press links gesture to Mac

• Status: RESOLVED
• Resolution: WONTFIX
• Component: UI Events

[Peyton Randolph]

Mac Safari would like a long-press gesture for links. Long-pressing on a link would send metadata, like the link's URL, title, and position, up to Safari.

[Peyton Randolph]

Created attachment 233986 [details]
Feature flag

[Peyton Randolph]

Created attachment 234003 [details]
Feature flag

[WebKit Commit Bot]

Comment on attachment 234003 [details]
Feature flag

Clearing flags on attachment: 234003

Committed r170550: <http://trac.webkit.org/changeset/170550>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Peyton Randolph]

More patches coming.

[Sam Weinig]

Why is this 10.10 only? Does it require new AppKit API?

[Peyton Randolph]

(In reply to comment #6)
> Why is this 10.10 only? Does it require new AppKit API?

I made it 10.10-only because the Safari-land feature it's supporting needs 10.10. But there's no technical reason to require 10.10 on the WebKit side, so if we'd like, we could enable it for 10.8 and 10.9.

[Sam Weinig]

(In reply to comment #7)
> (In reply to comment #6)
> > Why is this 10.10 only? Does it require new AppKit API?
> 
> I made it 10.10-only because the Safari-land feature it's supporting needs 10.10. But there's no technical reason to require 10.10 on the WebKit side, so if we'd like, we could enable it for 10.8 and 10.9.

Yes. Please enable everywhere.

[Peyton Randolph]

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Why is this 10.10 only? Does it require new AppKit API?
> > 
> > I made it 10.10-only because the Safari-land feature it's supporting needs 10.10. But there's no technical reason to require 10.10 on the WebKit side, so if we'd like, we could enable it for 10.8 and 10.9.
> 
> Yes. Please enable everywhere.

Everywhere Mac or everywhere everywhere?

[Peyton Randolph]

Comment on attachment 234003 [details]
Feature flag

Committed r170550.

[Peyton Randolph]

Created attachment 234101 [details]
Event handling

[Tim Horton]

Comment on attachment 234101 [details]
Event handling

View in context: https://bugs.webkit.org/attachment.cgi?id=234101&action=review

Will cc some relevant people.

> Source/WebCore/ChangeLog:3
> +        Add link long-press event handling using a timer.

we usually use one bug per patch. this bug already landed a patch :) might want to adjust the titles a bit

[Peyton Randolph]

(In reply to comment #12)
> (From update of attachment 234101 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234101&action=review
> 
> Will cc some relevant people.
> 
> > Source/WebCore/ChangeLog:3
> > +        Add link long-press event handling using a timer.
> 
> we usually use one bug per patch. this bug already landed a patch :) might want to adjust the titles a bit

Sure thing.

[Peyton Randolph]

(In reply to comment #13)
> (In reply to comment #12)
> > (From update of attachment 234101 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=234101&action=review
> > 
> > Will cc some relevant people.
> > 
> > > Source/WebCore/ChangeLog:3
> > > +        Add link long-press event handling using a timer.
> > 
> > we usually use one bug per patch. this bug already landed a patch :) might want to adjust the titles a bit
> 
> Sure thing.

Created a bug to track this subtask: https://bugs.webkit.org/show_bug.cgi?id=134612

[Peyton Randolph]

Superseded by https://bugs.webkit.org/show_bug.cgi?id=135257