Bug 134258 – [XHR] Realign bool members of XmlHttpRequest to reduce padding

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mahesh Kulkarni]

[XHR] Realign bool members of XmlHttpRequest to reduce padding

[Mahesh Kulkarni]

Created attachment 233723 [details]
Patch

[Laszlo Gombos]

+ Alexey

[Alexey Proskuryakov]

I guess it's OK to do, but it also seems pretty pointless. Is there a measurable improvement on any test from this patch?

[Mahesh Kulkarni]

(In reply to comment #3)
> I guess it's OK to do, but it also seems pretty pointless. Is there a measurable improvement on any test from this patch?

ap, with this minor optimization in realigning order of bool members, sizeof(xhr) is down by 16bytes (on 64bit machine. Also generally a good practice to move all small members towards the end of class). Though xhr aren't objects kept for long in memory, idea behind this patch to help readability and good practice (i.e Using bitfields/bitmask saves same amount of memory but effects code readability).

[Brent Fulgham]

Comment on attachment 233723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233723&action=review

This patch is too old to apply cleanly. However, I strongly agree with the code change. Could you please update this so that it applies against current sources?

> Source/WebCore/xml/XMLHttpRequest.h:259
>      bool m_responseCacheIsValid;

If you are making this change, please use C++11 initialization.

[Rob Buis]

This is fixed using bitfields in ToT.